Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Upgrade kube-proxy daemonset as part of KCP upgrades #2559

Merged
merged 2 commits into from
Mar 9, 2020
Merged

✨Upgrade kube-proxy daemonset as part of KCP upgrades #2559

merged 2 commits into from
Mar 9, 2020

Conversation

sedefsavas
Copy link

@sedefsavas sedefsavas commented Mar 6, 2020 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes
Fixes #2544

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @sedefsavas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2020
@k8s-ci-robot k8s-ci-robot requested review from chuckha and vincepri March 6, 2020 00:09
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2020
detiber
detiber reviewed Mar 6, 2020
View reviewed changes
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start, added some feedback based on the current state of the PR

controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
@detiber
Copy link
Member

detiber commented Mar 6, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2020
@ncdc ncdc mentioned this pull request Mar 6, 2020
Merged
@vincepri
Copy link
Member

vincepri commented Mar 6, 2020

/milestone v0.3.0

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Mar 6, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2020
@sedefsavas sedefsavas changed the title [WIP] 🐛Update kube-proxy daemonset image tag during KCP upgrade 🐛Update kube-proxy daemonset image tag during KCP upgrade Mar 9, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2020
@sedefsavas sedefsavas force-pushed the kubeproxy branch 2 times, most recently from 0a63299 to a0193ba Compare March 9, 2020 16:28
vincepri
vincepri approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold cancel
/assign @ncdc @detiber
for final review/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020
@vincepri
Copy link
Member

vincepri commented Mar 9, 2020

/retitle ✨Upgrade kube-proxy daemonset as part of KCP upgrades

@k8s-ci-robot k8s-ci-robot changed the title 🐛Update kube-proxy daemonset image tag during KCP upgrade ✨Upgrade kube-proxy daemonset as part of KCP upgrades Mar 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@detiber
Copy link
Member

detiber commented Mar 9, 2020

lgtm

@ncdc
Copy link
Contributor

ncdc commented Mar 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020
@vincepri
Copy link
Member

vincepri commented Mar 9, 2020

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

@k8s-ci-robot k8s-ci-robot merged commit 417ecad into kubernetes-sigs:master Mar 9, 2020
This was referenced Mar 9, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yastij yastij yastij left review comments

@detiber detiber detiber left review comments

@neolit123 neolit123 neolit123 left review comments

@ncdc ncdc ncdc left review comments

@vincepri vincepri vincepri approved these changes

@chuckha chuckha Awaiting requested review from chuckha

Assignees

@ncdc ncdc

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

KCP: Handle kube-proxy upgrades
7 participants
@sedefsavas @k8s-ci-robot @detiber @vincepri @ncdc @neolit123 @yastij